Codegen simd intrinsics as simd clif instructions #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
added
C-enhancement
bjorn3
force-pushed
the
real_simd
branch
2 times, most recently
from
43f9cc0 to
64ca38e
Compare
|
This spuriously hits https://github.com/bytecodealliance/cranelift/issues/1311. Going to cherry pick some comments and keeping the rest until https://github.com/bytecodealliance/cranelift/issues/1311 is fixed. |
|
I think the error was because I pushed a bad commit between the moment travis job of the previous commit began and the moment the macOS builders checked out this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simd values are still stored on the stack, so this doesn't improve performance much yet.
cc #171